rename variables to fit golang guidelines

pull/15/head
Simon Let 6 years ago
parent 22a0bf3f5e
commit ff763252f5
  1. 40
      collect/resh-collect.go
  2. 36
      common/resh-common.go
  3. 4
      evaluate/resh-evaluate.go
  4. 2
      sanitize-history/resh-sanitize-history.go

@ -30,9 +30,9 @@ func main() {
usr, _ := user.Current() usr, _ := user.Current()
dir := usr.HomeDir dir := usr.HomeDir
configPath := filepath.Join(dir, "/.config/resh.toml") configPath := filepath.Join(dir, "/.config/resh.toml")
reshUuidPath := filepath.Join(dir, "/.resh/resh-uuid") reshUUIDPath := filepath.Join(dir, "/.resh/resh-uuid")
machineIdPath := "/etc/machine-id" machineIDPath := "/etc/machine-id"
var config common.Config var config common.Config
if _, err := toml.DecodeFile(configPath, &config); err != nil { if _, err := toml.DecodeFile(configPath, &config); err != nil {
@ -48,7 +48,7 @@ func main() {
exitCode := flag.Int("exitCode", -1, "exit code") exitCode := flag.Int("exitCode", -1, "exit code")
shell := flag.String("shell", "", "actual shell") shell := flag.String("shell", "", "actual shell")
uname := flag.String("uname", "", "uname") uname := flag.String("uname", "", "uname")
sessionId := flag.String("sessionId", "", "resh generated session id") sessionID := flag.String("sessionId", "", "resh generated session id")
// posix variables // posix variables
cols := flag.String("cols", "-1", "$COLUMNS") cols := flag.String("cols", "-1", "$COLUMNS")
@ -82,10 +82,10 @@ func main() {
timezoneBefore := flag.String("timezoneBefore", "", "") timezoneBefore := flag.String("timezoneBefore", "", "")
timezoneAfter := flag.String("timezoneAfter", "", "") timezoneAfter := flag.String("timezoneAfter", "", "")
osReleaseId := flag.String("osReleaseId", "", "/etc/os-release ID") osReleaseID := flag.String("osReleaseId", "", "/etc/os-release ID")
osReleaseVersionId := flag.String("osReleaseVersionId", "", osReleaseVersionID := flag.String("osReleaseVersionId", "",
"/etc/os-release ID") "/etc/os-release ID")
osReleaseIdLike := flag.String("osReleaseIdLike", "", "/etc/os-release ID") osReleaseIDLike := flag.String("osReleaseIdLike", "", "/etc/os-release ID")
osReleaseName := flag.String("osReleaseName", "", "/etc/os-release ID") osReleaseName := flag.String("osReleaseName", "", "/etc/os-release ID")
osReleasePrettyName := flag.String("osReleasePrettyName", "", osReleasePrettyName := flag.String("osReleasePrettyName", "",
"/etc/os-release ID") "/etc/os-release ID")
@ -161,8 +161,8 @@ func main() {
*gitRemote = "" *gitRemote = ""
} }
if *osReleaseId == "" { if *osReleaseID == "" {
*osReleaseId = "linux" *osReleaseID = "linux"
} }
if *osReleaseName == "" { if *osReleaseName == "" {
*osReleaseName = "Linux" *osReleaseName = "Linux"
@ -177,7 +177,7 @@ func main() {
ExitCode: *exitCode, ExitCode: *exitCode,
Shell: *shell, Shell: *shell,
Uname: *uname, Uname: *uname,
SessionId: *sessionId, SessionID: *sessionID,
// posix // posix
Cols: *cols, Cols: *cols,
@ -220,15 +220,15 @@ func main() {
GitDir: gitDir, GitDir: gitDir,
GitRealDir: gitRealDir, GitRealDir: gitRealDir,
GitOriginRemote: *gitRemote, GitOriginRemote: *gitRemote,
MachineId: readFileContent(machineIdPath), MachineID: readFileContent(machineIDPath),
OsReleaseId: *osReleaseId, OsReleaseID: *osReleaseID,
OsReleaseVersionId: *osReleaseVersionId, OsReleaseVersionID: *osReleaseVersionID,
OsReleaseIdLike: *osReleaseIdLike, OsReleaseIDLike: *osReleaseIDLike,
OsReleaseName: *osReleaseName, OsReleaseName: *osReleaseName,
OsReleasePrettyName: *osReleasePrettyName, OsReleasePrettyName: *osReleasePrettyName,
ReshUuid: readFileContent(reshUuidPath), ReshUUID: readFileContent(reshUUIDPath),
ReshVersion: Version, ReshVersion: Version,
ReshRevision: Revision, ReshRevision: Revision,
} }
@ -236,13 +236,13 @@ func main() {
} }
func sendRecord(r common.Record, port string) { func sendRecord(r common.Record, port string) {
recJson, err := json.Marshal(r) recJSON, err := json.Marshal(r)
if err != nil { if err != nil {
log.Fatal("send err 1", err) log.Fatal("send err 1", err)
} }
req, err := http.NewRequest("POST", "http://localhost:"+port+"/record", req, err := http.NewRequest("POST", "http://localhost:"+port+"/record",
bytes.NewBuffer(recJson)) bytes.NewBuffer(recJSON))
if err != nil { if err != nil {
log.Fatal("send err 2", err) log.Fatal("send err 2", err)
} }
@ -279,14 +279,14 @@ func getGitDirs(cdup string, exitCode int, pwd string) (string, string) {
func getTimezoneOffsetInSeconds(zone string) float64 { func getTimezoneOffsetInSeconds(zone string) float64 {
// date +%z -> "+0200" // date +%z -> "+0200"
hours_str := zone[:3] hoursStr := zone[:3]
mins_str := zone[3:] minsStr := zone[3:]
hours, err := strconv.Atoi(hours_str) hours, err := strconv.Atoi(hoursStr)
if err != nil { if err != nil {
log.Println("err while parsing hours in timezone offset:", err) log.Println("err while parsing hours in timezone offset:", err)
return -1 return -1
} }
mins, err := strconv.Atoi(mins_str) mins, err := strconv.Atoi(minsStr)
if err != nil { if err != nil {
log.Println("err while parsing mins in timezone offset:", err) log.Println("err while parsing mins in timezone offset:", err)
return -1 return -1

@ -14,7 +14,7 @@ type Record struct {
ExitCode int `json:"exitCode"` ExitCode int `json:"exitCode"`
Shell string `json:"shell"` Shell string `json:"shell"`
Uname string `json:"uname"` Uname string `json:"uname"`
SessionId string `json:"sessionId"` SessionID string `json:"sessionId"`
// posix // posix
Cols string `json:"cols"` Cols string `json:"cols"`
@ -57,15 +57,15 @@ type Record struct {
GitDir string `json:"gitDir"` GitDir string `json:"gitDir"`
GitRealDir string `json:"gitRealDir"` GitRealDir string `json:"gitRealDir"`
GitOriginRemote string `json:"gitOriginRemote"` GitOriginRemote string `json:"gitOriginRemote"`
MachineId string `json:"machineId"` MachineID string `json:"machineId"`
OsReleaseId string `json:"osReleaseId"` OsReleaseID string `json:"osReleaseId"`
OsReleaseVersionId string `json:"osReleaseVersionId"` OsReleaseVersionID string `json:"osReleaseVersionId"`
OsReleaseIdLike string `json:"osReleaseIdLike"` OsReleaseIDLike string `json:"osReleaseIdLike"`
OsReleaseName string `json:"osReleaseName"` OsReleaseName string `json:"osReleaseName"`
OsReleasePrettyName string `json:"osReleasePrettyName"` OsReleasePrettyName string `json:"osReleasePrettyName"`
ReshUuid string `json:"reshUuid"` ReshUUID string `json:"reshUuid"`
ReshVersion string `json:"reshVersion"` ReshVersion string `json:"reshVersion"`
ReshRevision string `json:"reshRevision"` ReshRevision string `json:"reshRevision"`
@ -88,7 +88,7 @@ type FallbackRecord struct {
ExitCode int `json:"exitCode"` ExitCode int `json:"exitCode"`
Shell string `json:"shell"` Shell string `json:"shell"`
Uname string `json:"uname"` Uname string `json:"uname"`
SessionId string `json:"sessionId"` SessionID string `json:"sessionId"`
// posix // posix
Cols int `json:"cols"` // notice the in type Cols int `json:"cols"` // notice the in type
@ -131,15 +131,15 @@ type FallbackRecord struct {
GitDir string `json:"gitDir"` GitDir string `json:"gitDir"`
GitRealDir string `json:"gitRealDir"` GitRealDir string `json:"gitRealDir"`
GitOriginRemote string `json:"gitOriginRemote"` GitOriginRemote string `json:"gitOriginRemote"`
MachineId string `json:"machineId"` MachineID string `json:"machineId"`
OsReleaseId string `json:"osReleaseId"` OsReleaseID string `json:"osReleaseId"`
OsReleaseVersionId string `json:"osReleaseVersionId"` OsReleaseVersionID string `json:"osReleaseVersionId"`
OsReleaseIdLike string `json:"osReleaseIdLike"` OsReleaseIDLike string `json:"osReleaseIdLike"`
OsReleaseName string `json:"osReleaseName"` OsReleaseName string `json:"osReleaseName"`
OsReleasePrettyName string `json:"osReleasePrettyName"` OsReleasePrettyName string `json:"osReleasePrettyName"`
ReshUuid string `json:"reshUuid"` ReshUUID string `json:"reshUuid"`
ReshVersion string `json:"reshVersion"` ReshVersion string `json:"reshVersion"`
ReshRevision string `json:"reshRevision"` ReshRevision string `json:"reshRevision"`
} }
@ -152,7 +152,7 @@ func ConvertRecord(r *FallbackRecord) Record {
ExitCode: r.ExitCode, ExitCode: r.ExitCode,
Shell: r.Shell, Shell: r.Shell,
Uname: r.Uname, Uname: r.Uname,
SessionId: r.SessionId, SessionID: r.SessionID,
// posix // posix
// these two lines are the only reason we are doing this // these two lines are the only reason we are doing this
@ -196,15 +196,15 @@ func ConvertRecord(r *FallbackRecord) Record {
GitDir: r.GitDir, GitDir: r.GitDir,
GitRealDir: r.GitRealDir, GitRealDir: r.GitRealDir,
GitOriginRemote: r.GitOriginRemote, GitOriginRemote: r.GitOriginRemote,
MachineId: r.MachineId, MachineID: r.MachineID,
OsReleaseId: r.OsReleaseId, OsReleaseID: r.OsReleaseID,
OsReleaseVersionId: r.OsReleaseVersionId, OsReleaseVersionID: r.OsReleaseVersionID,
OsReleaseIdLike: r.OsReleaseIdLike, OsReleaseIDLike: r.OsReleaseIDLike,
OsReleaseName: r.OsReleaseName, OsReleaseName: r.OsReleaseName,
OsReleasePrettyName: r.OsReleasePrettyName, OsReleasePrettyName: r.OsReleasePrettyName,
ReshUuid: r.ReshUuid, ReshUUID: r.ReshUUID,
ReshVersion: r.ReshVersion, ReshVersion: r.ReshVersion,
ReshRevision: r.ReshRevision, ReshRevision: r.ReshRevision,
} }

@ -186,10 +186,10 @@ func (e *evaluator) processRecords() {
var nextID uint64 var nextID uint64
nextID = 0 nextID = 0
for k, record := range e.UsersRecords[i].Devices[j].Records { for k, record := range e.UsersRecords[i].Devices[j].Records {
id, found := sessionIDs[record.SessionId] id, found := sessionIDs[record.SessionID]
if found == false { if found == false {
id = nextID id = nextID
sessionIDs[record.SessionId] = id sessionIDs[record.SessionID] = id
nextID++ nextID++
} }
record.SeqSessionID = id record.SeqSessionID = id

@ -153,7 +153,7 @@ func (s *sanitizer) sanitizeRecord(record *common.Record) error {
// hash the most sensitive info, do not tokenize // hash the most sensitive info, do not tokenize
record.Host = s.hashToken(record.Host) record.Host = s.hashToken(record.Host)
record.Login = s.hashToken(record.Login) record.Login = s.hashToken(record.Login)
record.MachineId = s.hashToken(record.MachineId) record.MachineID = s.hashToken(record.MachineID)
var err error var err error
// this changes git url a bit but I'm still happy with the result // this changes git url a bit but I'm still happy with the result

Loading…
Cancel
Save